-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopted the bdist_wheel command from "wheel" #4369
Conversation
@jaraco I'll need some assistance, perhaps during the sprints, to figure out why there are so many errors/failures. The test suite didn't pass for me locally even with a pristine copy of the repo without my changes, but these changes seemed to have introduced tons of additional errors and failures. |
Just a wild guess, but maybe it also needs to be bootstrapped in https://github.com/pypa/setuptools/blob/main/bootstrap.egg-info/entry_points.txt? |
I have no clue. Can you make sense of the errors in CI? It's like at least some of them have nothing to do with this change. |
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
For some reason when you run # Python 3.12 (pipx run --python python3.12 tox -e vendor)
new file: pkg_resources/_vendor/backports/tarfile/__init__.py
new file: pkg_resources/_vendor/backports/tarfile/__main__.py
new file: pkg_resources/_vendor/backports/tarfile/compat/__init__.py
new file: pkg_resources/_vendor/backports/tarfile/compat/py38.py
new file: setuptools/_vendor/backports/tarfile/__init__.py
new file: setuptools/_vendor/backports/tarfile/__main__.py
new file: setuptools/_vendor/backports/tarfile/compat/__init__.py
new file: setuptools/_vendor/backports/tarfile/compat/py38.py # Python 3.8 (pipx run --python python3.8 tox -e vendor)
new file: pkg_resources/_vendor/backports/tarfile/__init__.py
new file: pkg_resources/_vendor/backports/tarfile/__main__.py
new file: pkg_resources/_vendor/backports/tarfile/compat/__init__.py
new file: pkg_resources/_vendor/backports/tarfile/compat/py38.py
new file: setuptools/_vendor/backports/tarfile/__init__.py
new file: setuptools/_vendor/backports/tarfile/__main__.py
new file: setuptools/_vendor/backports/tarfile/compat/__init__.py
new file: setuptools/_vendor/backports/tarfile/compat/py38.py I think these files need to be included. There also seems to be a problems with static check: .tox/py/lib/python3.12/site-packages/pytest_mypy.py:212: MypyWarning
_________________________________ setuptools/tests/test_bdist_wheel.py _________________________________
[gw4] linux -- Python 3.12.3 /home/abravalheri/workspace/setuptools/.tox/py/bin/python
458: error: Cannot find implementation or library stub for module named "wheel" [import-not-found]
458: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Maybe this solves the problem: diff --git i/setuptools/tests/test_bdist_wheel.py w/setuptools/tests/test_bdist_wheel.py
index 161fb88e2..1f8e76e30 100644
--- i/setuptools/tests/test_bdist_wheel.py
+++ w/setuptools/tests/test_bdist_wheel.py
@@ -455,6 +455,6 @@ def test_no_ctypes(monkeypatch) -> None:
if module.startswith("wheel"):
monkeypatch.delitem(sys.modules, module)
- from wheel import bdist_wheel
+ from setuptools.command import bdist_wheel
assert bdist_wheel I am still having a look on the other errors that appeared. |
"pip wheel" won't work without it for now.
Adapted to changes in |
Thanks Alex for the work here. I've added @agronholm as a Setuptools Developer. Please feel free to merge. |
Since pypa/setuptools#4369 was merged, wheel is vendored into setuptools and no longer needs to be installed for `bdist_wheel` to work.
Since pypa/setuptools#4369 was merged, wheel is vendored into setuptools and no longer needs to be installed for `bdist_wheel` to work.
Since pypa/setuptools#4369 was merged, wheel is vendored into setuptools and no longer needs to be installed for `bdist_wheel` to work.
The bdist_wheel command is now part of setuptools pypa/setuptools#4369
A bit late to the game? This was merged 3 months ago. |
…ols' The `bdist_wheel` module was moved from the "wheel" pkg to the "setuptools" package. This means we need either an old version of wheel or a new version of setuptools. fixes #3 ref pypa/wheel#631 ref pypa/setuptools#4369
Summary of changes
This adopts the
bdist_wheel
command and vendors most of thewheel
code.Closes #1386.
Pull Request Checklist
newsfragments/
.(See documentation for details)
NOTE: Coverage reports missing lines in
test_bdist_wheel
but those would be handled with combined coverage reporting.